Re: [Patch / 002](memory hotplug) Callback function to createkmem_cache_node.

From: Christoph Lameter
Date: Mon Oct 01 2007 - 16:35:23 EST


On Mon, 1 Oct 2007, Yasunori Goto wrote:

> +#ifdef CONFIG_MEMORY_HOTPLUG
> +static void __slab_callback_offline(int nid)
> +{
> + struct kmem_cache_node *n;
> + struct kmem_cache *s;
> +
> + list_for_each_entry(s, &slab_caches, list) {
> + if (s->node[nid]) {
> + n = get_node(s, nid);
> + s->node[nid] = NULL;
> + kmem_cache_free(kmalloc_caches, n);
> + }
> + }
> +}

I think we need to bug here if there are still objects on the node that
are in use. This will silently discard the objects.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/