Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()

[Zach Brown]

> 	return ERR_PTR(PTR_ERR(inode));
>
> I tend to prefer the latter.

It seems like a pretty noisy way to get a (void *) cast :/.  Maybe a  
function that has the cast but makes sure it's only used for IS_ERR()  
pointers?

/* haha, continuing the fine tradition of terrible names in this  
api..  */
static inline void *PTR_PTR(void *err_ptr) {
	BUG_ON(!IS_ERR(err_ptr) || !err_ptr);
	return err_ptr;
}

Meh.

- z
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/