Re: [PATCH] PCI: nVidia's MCP61 ethernet card needs quirk for wrongclass

From: Jiri Kosina
Date: Mon Oct 01 2007 - 11:24:56 EST


On Mon, 1 Oct 2007, Jeff Garzik wrote:

> > > There are other network devices that do not claim
> > > PCI_CLASS_NETWORK_ETHERNET either.
> > Nor any other PCI_CLASS_NETWORK subclass?
> Correct.

BTW do you have some examples off the top of your head?

> > What would you recommend as a method for userspace to detect whether
> > given hardware is a network card, supposing that there is no driver
> > bound to it yet?
> Note the mention of "weird cases" You come up with a general method,
> then you have to deal with exceptions to that general method.

Sure. Still don't see why to do it in kernel, when it is hardware-related
though.

> Another example: 8139too and 8139cp both claim to support
> (0x10EC,0x8139) PCI IDs. The distro installer needs additional
> information to know to read the PCI revision, which is what determines
> whether or not to use 8139cp driver.

That's also pretty ugly, sure.

> Sometimes life is just not as simple as you would like it to be :)

You tell me :) There is a load of quirks for individual devices that claim
themselves to be HID-compliant, but break the specs in various different
creative ways :)

--
Jiri Kosina
SUSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/