Re: [PATCH] PCI: nVidia's MCP61 ethernet card needs quirk for wrongclass

From: Jiri Kosina
Date: Mon Oct 01 2007 - 11:03:08 EST


On Mon, 1 Oct 2007, Jeff Garzik wrote:

> There are other network devices that do not claim
> PCI_CLASS_NETWORK_ETHERNET either.

Nor any other PCI_CLASS_NETWORK subclass?

> Since this is a purely cosmetic issue -- said userland tools would need
> to support weird cases _anyway_ -- I am not inclined to apply the patch.

What would you recommend as a method for userspace to detect whether given
hardware is a network card, supposing that there is no driver bound to it
yet?

> The kernel could do a lot to make things "prettier," but that would lead
> to lots of additional code bloat. It's easier to export the world as it
> is, and let the chips fall where they may.

OK, I don't seem to agree with you on this matter, let's wait for Greg's
oppinion.

Thanks,

--
Jiri Kosina
SUSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/