Re: [PATCH] removes array_size duplicates

[Andrew Morton]

On Mon, 1 Oct 2007 11:33:01 +0200 (CEST) Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:

> On Mon, 1 Oct 2007, Andrew Morton wrote:
> > On Fri, 28 Sep 2007 00:51:13 +0200 roel <12o3l@xxxxxxxxxx> wrote:
> > > This patch removes some ARRAY_SIZE macro duplicates. There is also one in
> > > arch/um/include/user.h, which isn't fixed here because comments in that file
> > > explicitly state a preference for the 'less fancy' version. If that's the
> > > case as well for any of the other replacements please comment.
> > 
> > I got a bunch of rejects against various development trees, a 
> > build error in net/ipv4/ipvs/ip_vs_proto_udp.c and now
> > 
> > net/netfilter/xt_sctp.c: In function 'match_packet':
> > net/netfilter/xt_sctp.c:58: error: size of array 'type name' is negative
> > net/netfilter/xt_sctp.c:106: error: size of array 'type name' is negative
> 
> However, arch/m68k/amiga/amisound.c:
> Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> 

Well yes.  If the change had been split up into separate per-subsystem patches I
wouldn't have needed to drop the whole lot.  Hint.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/