Re: [PATCH] libata drain fifo on stuck DRQ HSM violation

From: Mark Lord
Date: Sat Sep 29 2007 - 08:34:30 EST


Alan Cox wrote:
Why 512 words ?
Though I have queued Mark's patch to be applied, my gut feeling would lean towards a single DRQ block, rather than 512.

Why not just work from the old IDE code.

ata_altstatus(ap);
- ata_chk_status(ap);
+ ata_drain_fifo(ap, qc);
ap->ops->cleanup();

might be wiser
If someone needs that, they can override the error handler with their own. No need for a new op.

PDC202xx needs

Alan, you're the expert there (my condolences!).
Can you generate a fix for the PDC202xx to go with this?

Cheers
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/