Re: [PATCH] update checkpatch.pl to version 0.10

From: Andy Whitcroft
Date: Sat Sep 29 2007 - 05:22:39 EST


On Fri, Sep 28, 2007 at 10:46:42AM -0700, Andrew Morton wrote:
> On Fri, 28 Sep 2007 14:21:38 +0100 Andy Whitcroft <apw@xxxxxxxxxxxx> wrote:
>
> > On Fri, Sep 28, 2007 at 12:49:35PM +0200, Ingo Molnar wrote:
> > >
> > > * Andy Whitcroft <apw@xxxxxxxxxxxx> wrote:
> > >
> > > > On Fri, Sep 28, 2007 at 11:39:02AM +0200, Ingo Molnar wrote:
> > > >
> >
> > [bunfight]
> >
>
> oy, knock it off.

Really not trying to have a bunfight, honest.

> > Anyhow. I have already added a --check/--no-check option which controls
>
> -strict?
>
> > the more subjective tests which will be in the next release; though its
> > likely the option name will be something more useful by then.
> >
> > The only question is whether this should default to on. You are voting
> > off. I personally think on.
> >
> > Andrew? Randy? Joel?
> >
>
> off, I'd say. That way people are more likely to use it. Or, more
> accurately, will have less excuses to not use it.

Ok, then I think thats 2 for on and 3 for off. So off it is.

I was tending towards --subjective for the tests which are err more
subjective. --strict is good too. Perhaps I'll put both of those in as
aliases.

I will also review the tests which are warnings and checks (subjective)
and see if any are now miss-categorised.

-apw
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/