Re: [PATCH] spin_lock_unlocked cleanups

From: Mark Gross
Date: Fri Sep 28 2007 - 13:32:28 EST


On Fri, Sep 28, 2007 at 01:26:56AM -0700, Andrew Morton wrote:
> On Fri, 28 Sep 2007 10:17:30 +0200 Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>
> > can we please add this to checkpatch.pl ?
> >
> > > -spinlock_t bpci_lock = SPIN_LOCK_UNLOCKED;
> > > +DEFINE_SPINLOCK(bpci_lock);
>
> That check is already in checkpatch. Problem is that hardly anyone
> runs the thing.
>
> I think we're ready to wire checkpatch up to a email robot which monitors
> the mailing lists and sends people nastygrams. I bet that'll be popular ;)

One could make check patch create a signature hashing a check patch key
and the patch one could put in the post like a signed-off-by: thing.

checkpatch-sig : 2f818bcf0c2333a461affc4a170814f23adf2e08

this puts the burden on the sender to run the thing.

--mgross
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/