Re: [PATCH] disable non-boot CPUs before poweroff

From: Thomas Gleixner
Date: Fri Sep 28 2007 - 10:55:55 EST



On Fri, 2007-09-28 at 09:52 -0400, Mark Lord wrote:
> We need to disable all CPUs other than the boot CPU (usually 0)
> before attempting to power-off modern SMP machines.
> This seems to fix the hang-on-poweroff issue
> that one of my SMP boxes exhibits. More testing required.
>
> Signed-off-by: Mark Lord <mlord@xxxxxxxxx>

Fixes my new toybox as well. Thanks for tracking it down before I had to
dig in.

Acked-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>

> ---
>
> --- linux/kernel/sys.c.orig 2007-09-13 09:49:11.000000000 -0400
> +++ linux/kernel/sys.c 2007-09-28 09:48:54.000000000 -0400
> @@ -32,6 +32,7 @@
> #include <linux/getcpu.h>
> #include <linux/task_io_accounting_ops.h>
> #include <linux/seccomp.h>
> +#include <linux/cpu.h>
>
> #include <linux/compat.h>
> #include <linux/syscalls.h>
> @@ -879,6 +880,7 @@
> if (pm_power_off_prepare)
> pm_power_off_prepare();
> sysdev_shutdown();
> + disable_nonboot_cpus();
> printk(KERN_EMERG "Power down.\n");
> machine_power_off();
> }
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/