Re: [PATCH] spin_lock_unlocked cleanups

[Thomas Gleixner]

On Fri, 2007-09-28 at 01:26 -0700, Andrew Morton wrote:
> On Fri, 28 Sep 2007 10:17:30 +0200 Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> 
> > can we please add this to checkpatch.pl ? 
> > 
> > > -spinlock_t bpci_lock = SPIN_LOCK_UNLOCKED;
> > > +DEFINE_SPINLOCK(bpci_lock);
> 
> That check is already in checkpatch.  Problem is that hardly anyone
> runs the thing.

Sigh, I forgot that perl is write only. :)

> I think we're ready to wire checkpatch up to a email robot which monitors
> the mailing lists and sends people nastygrams.  I bet that'll be popular ;)

We should wire it up to git-commit as well. A lot of that comes in via
git subsystems.

> (I'd love it if it could detect wordwrapped and tab-expanded patches, too. 
> You wouldn't _believe_...)

I know ...

	tglx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/