Re: [PATCH] spin_lock_unlocked cleanups

From: Ingo Molnar
Date: Fri Sep 28 2007 - 04:31:01 EST

* Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Fri, 28 Sep 2007 10:17:30 +0200 Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> > can we please add this to ?
> >
> > > -spinlock_t bpci_lock = SPIN_LOCK_UNLOCKED;
> > > +DEFINE_SPINLOCK(bpci_lock);
> That check is already in checkpatch. Problem is that hardly anyone
> runs the thing.

i automatically run it for every patch i submit or push out via git.

> I think we're ready to wire checkpatch up to a email robot which
> monitors the mailing lists and sends people nastygrams. I bet that'll
> be popular ;)

heh ;-) It could be automated for patches that are sent out with a
Signed-off-by [or a Reviewed-by] line. If you send a SoB patch that is
broken, prepare to get a nastygram. (Initially i'd suggest the nastygram
to Cc: to a different email list, not lkml.)

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at