Re: [PATCH 06/12] mm: remove raw SetPageLocked() usage

From: Christoph Hellwig
Date: Fri Sep 28 2007 - 04:22:53 EST

 error = radix_tree_insert(&mapping->page_tree, offset, page);
> if (!error) {
> page_cache_get(page);

I don't think we want an unchecked trylock_page without a comment explaining
it. I'd go as far as saying trylock_page should get a __must_check
attribute, and we'll need a dummy variable to actually ignore it.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at