Re: [PATCH] bw-qcam: use data_reverse instead of manually pokingthe control register

From: Alan Cox
Date: Thu Sep 27 2007 - 17:25:28 EST

On Thu, 27 Sep 2007 12:28:31 -0700
"Brett Warden" <brett.warden@xxxxxxxxx> wrote:

> Fixes use of parport_write_control() to match the newer interface that
> requires explicit parport_data_reverse() and parport_data_forward()
> calls. This eliminates the following error message and restores the
> original intended behavior:

Looks good

> parport0 (bw-qcam): use data_reverse for this!
> Also increases threshold in qc_detect() from 300 to 400, as my camera
> often results in a count of approx 330. Added a kernel error message
> to indicate detection failure.


> Signed-off-by: Brett T. Warden <brett.warden@xxxxxxxxx>

Acked-by: Alan Cox <alan@xxxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at