Re: [REGRESSION from 2.6.23-rc8] (was: Re: 2.6.23-rc4-mm1 and -rc6-mm1: boot failure on HP nx6325, related to clockevents)

[Rafael J. Wysocki]

On Thursday, 27 September 2007 01:21, Thomas Gleixner wrote:
> On Thu, 2007-09-27 at 01:30 +0200, Rafael J. Wysocki wrote:
> > > > Tested for a couple of times with each kernel, the results seem to be
> > > > reproducible 100% of the time.
> > > 
> > > Thanks for going through this debug marathon.
> > 
> > No big deal.  I'm glad that you've found what's up.
> > 
> > Well, we still have the "CPU hotplug during suspend w/ the hrt patch" problem
> > to debug ... ;-)
> 
> Yeah. Knowing the actual line of code where it breaks might be helpful.

Instead, I have a fix (appended, against 2.6.23-rc8-mm2). :-)

Next, I'm going to enable NO_HZ and HIGH_RES_TIMERS and see what happens. ;-)

Greetings,
Rafael

---
From: Rafael J. Wysocki <rjw@xxxxxxx>

Fix CPU hotplug breakage on HP nx6325 and similar boxes caused by the reference
to disable_apic_timer (labeled as __initdata) from the CPU initialization code.

Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx>
---
 arch/x86_64/kernel/apic.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.23-rc8-mm2/arch/x86_64/kernel/apic.c
===================================================================
--- linux-2.6.23-rc8-mm2.orig/arch/x86_64/kernel/apic.c
+++ linux-2.6.23-rc8-mm2/arch/x86_64/kernel/apic.c
@@ -42,7 +42,7 @@
 
 int apic_verbosity;
 static int apic_calibrate_pmtmr __initdata;
-int disable_apic_timer __initdata;
+int disable_apic_timer __cpuinitdata;
 
 /* Local APIC timer works in C2? */
 int local_apic_timer_c2_ok;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/