Re: [PATCH 1/8] taskstats: fix indentation of long argument lists

From: Balbir Singh
Date: Thu Sep 27 2007 - 04:29:21 EST

Andrew Morton wrote:
> On Wed, 26 Sep 2007 19:08:18 +0200
> Guillaume Chazarain <guichaz@xxxxxxxx> wrote:
>> Align with the opening parenthesis.
>> Changelog since V1 (
>> - renamed fill_threadgroup() and add_tsk() to respectively
>> fill_threadgroup_stats() and add_tsk_stats() as suggested by Balbir Singh.
>> - added braces around do/while.
>> - added patch to unbreak binary compatibility between taskstats v5/v6.
>> - split further by preparing the bacct/xacct before the main patch.
>> - some indentation fixes.
> It is unclear to me whether this patch series replaces, augments or
> conflicts with your earlier patch series starting with "taskstats: separate
> PID/TGID stats producers to complete the TGID ones".
> But it doesn't matter much - I think I'll duck both patch series for now.
> The gap between mainline and -mm is so large that it is becoming
> unmanageable so let's concentrate on the review and stabilisation work for
> now please, rather than adding more stuff.
> Also, I don't think we're seeing enough review and test from people on
> these patch series - I don't have time to do it all. (Well, apparently I
> do, but I don't think it's a good situation).

Hi, Andrew,

I've been able to review some of these patches, but not test them.
I'll find some time to test these patches.

Warm Regards,
Balbir Singh
Linux Technology Center
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at