Re: [PATCH 3/4] Change dmapool free block management

From: David Miller
Date: Wed Sep 26 2007 - 17:13:35 EST


From: Matthew Wilcox <willy@xxxxxxxxxxxxxxx>
Date: Wed, 26 Sep 2007 15:01:18 -0400

> Also add documentation for how dma pools work, move the header above the
> includes, add my copyright, add the original author's copyright, add a
> GPL v2 licence to the file and fix the includes.
>
> Signed-off-by: Matthew Wilcox <willy@xxxxxxxxxxxxxxx>

Correct or not, you need to describe how you are changing the
free block management, why that transformation is valid and
worthwhile, etc.

I can see that you're getting rid of a bitmap and replacing it
with the dma_page->in_use et al. stuff, but you need to describe
that in detail.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/