Re: + uninline-find_task_by_xxx-set-of-functions.patch added to-mm tree

From: Ingo Molnar
Date: Wed Sep 26 2007 - 16:38:54 EST



* akpm@xxxxxxxxxxxxxxxxxxxx <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> ------------------------------------------------------
> Subject: Uninline find_task_by_xxx set of functions
> From: Pavel Emelyanov <xemul@xxxxxxxxxx>
>
> The find_task_by_something is a set of macros are used to find task by pid
> depending on what kind of pid is proposed - global or virtual one. All of
> them are wrappers above the most generic one - find_task_by_pid_type_ns() -
> and just substitute some args for it.
>
> It turned out, that dereferencing the current->nsproxy->pid_ns construction
> and pushing one more argument on the stack inline cause kernel text size to
> grow.
>
> This patch moves all this stuff out-of-line into kernel/pid.c. Together
> with the next patch it saves a bit less than 400 bytes from the .text
> section.
>
> Signed-off-by: Pavel Emelyanov <xemul@xxxxxxxxxx>
> Cc: Sukadev Bhattiprolu <sukadev@xxxxxxxxxx>
> Cc: Oleg Nesterov <oleg@xxxxxxxxxx>
> Cc: Paul Menage <menage@xxxxxxxxxx>
> Cc: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>

Acked-by: Ingo Molnar <mingo@xxxxxxx>

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/