Re: [PATCH 2/6] LBS: fix uninitialized swapper_space
From: Hugh Dickins
Date: Wed Sep 26 2007 - 14:35:18 EST
On Mon, 24 Sep 2007, Christoph Lameter wrote:
> On Fri, 21 Sep 2007, Hugh Dickins wrote:
> > Swapping crashed immediately: must initialize new fields of swapper_space.
> Thanks for finding that. It may be better though to use the new
> mapping_setup() function instead? That way there is no #ifdef.
Probably better, yes. In -mm Peter is doing an #ifdef CONFIG_SWAP
bdi_init() on swapper_space. Would make sense to do both together,
perhaps move them to a swapper_space_init() in swap_state.c, saving
his #ifdef too. I suggest leave such cleanups until one or the
other is mainlined.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/