Re: [PATCH 05/25] Unionfs: cast page->index loff_t before shifting

From: Erez Zadok
Date: Wed Sep 26 2007 - 09:45:20 EST


In message <20070926083121.GA8421@xxxxxxxxxxxxx>, Christoph Hellwig writes:
> On Tue, Sep 25, 2007 at 11:09:44PM -0400, Erez Zadok wrote:
> > Fixes bugs in number promotion/demotion computation, as per
> > <http://lkml.org/lkml/2007/9/20/17>
>
> It's better to use te page_offset helper as that avoids any confusion
> on where to cast.

Excellent. Will do.

Erez.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/