Re: Linux, pata_ali issue

From: Jan Engelhardt
Date: Tue Sep 25 2007 - 15:38:27 EST

On Sep 25 2007 10:35, Greg KH wrote:
>On Tue, Sep 25, 2007 at 07:03:24PM +0200, Jan Engelhardt wrote:

>> So, here is something that I think should go into the next 2.6.22.
>> A proper fix is already in 2.6.23-git-du-jour.
>Feel free to send the patch, with the git commit id of the upstream
>commit to the stable@xxxxxxxxxx address and we will be glad to review it
>that way.

'right, it is already in the mainline kernel.
So it's again the suse kernel src rpm that has it screwed up...
another story. Here's your culprit:

* Replaces ali_init_chipset() with some new bits, essentially
it removes the call to pci_read_config_byte() since the
revision is now found in struct pci_dev->revision
Basically 2.6.23 stuff.

* changes it back to the 2.6.22 api, so that it compiles again.
But only that.
It FORGETS to add pci_read_config_byte() back.

=== libata-fix-up-build-after-upstream-update.patch