Re: [PATCH] sata_nv,ahci: add the ahci legacy mode support to sata_nv
From: Jeff Garzik
Date: Tue Sep 25 2007 - 04:14:10 EST
Peer Chen wrote:
We have three mode for one controller - IDE/RAID/AHCI, we want sata_nv being load when user select the IDE mode in BIOS, load ahci driver if RAID/AHCI being selected, which will verify if our legacy mode work well and have additional option if there is any
bug for the ahci mode.
I understand that logic, but look at what happens in practice:
1) User installs new OS in AHCI mode. Distro updates initramfs (loaded
at kernel boot time, with boot drivers) to include ahci driver.
2) User reboots into BIOS setup, and switches from AHCI mode to IDE mode.
3) BIOS setup reboots computer.
4) OS kernel and initramfs image are loaded. ahci driver load fails.
5) User is left without a bootable system.
The same situation happens in reverse, if you install in IDE mode
(sata_nv in initramfs), and then switch to AHCI/RAID mode.
Additionally, AHCI provides better performance and more direct exposure
to the SATA frames. This is key for supporting many modern SATA
features that cannot be accessed via IDE legacy mode. AHCI lacks
in-silicon simulation of an IDE interface, which time has shown is a
less stable, edge-case-prone approach to SATA.
I do not find the "verify nvidia's legacy mode works" argument
compelling; that is not the kernel's job, nor the user's. And if there
is an AHCI silicon bug, let us deal with that when such a bug appears.
Overall, AFAICS this patch -introduces- new ways for the user to easily
render their systems unbootable.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/