Re: rtl8187 driver in 2.6.23-rc6-git5: kernel panic if not used asa module. Works as a module.

From: Eric Valette
Date: Tue Sep 25 2007 - 04:07:17 EST


Rob Hussey wrote:
> On 9/15/07, ããããããã Paul Rolland <rol@xxxxxxxxx> wrote:
>
>> Hi Eric,
>>
>> On Sat, 15 Sep 2007 20:30:14 +0200
>> Eric Valette <eric.valette@xxxxxxx> wrote:
>>
>>
>>> Rob Hussey wrote:
>>>
>>>> On 9/15/07, Eric Valette <eric.valette@xxxxxxx> wrote:
>>>>
>>>>> Eric Valette wrote:
>>>>>
>>>>>
>>> Thanks for your help: it does indeed fix the problem.
>>>
>> Nice it works for you too !
>>
>>
>>> Now I have two side questions:
>>> - the code is no more symetric "subsys_initcall" -> "module_exit".
>>> Do not know if it is "normal" but I love symmetry in code :-). Did not test
>>> it still works as a module...
>>>
>> Symmetry is not broken, as we have :
>> #define subsys_initcall(fn) module_init(fn)
>> in include/linux/init.h where compiling as a module, and when not compiling
>> as a module, I doubt the exit function is called unless you are shuting
>> down your machine...
>>
>>
>>> - Who takes the responsability to push a patch to Linus? I guess it
>>> is urgent unless he plans a rc7
>>>
>> Good point ! I expect the patches to be already in some queue waiting to be
>> pulled !
>>
>
> The patches are on their way to making it into 2.6.23:
> http://marc.info/?l=linux-netdev&m=118986368303529&w=2
>
> Regards,
> Rob
>
I'm a little bit worried as rc8 is out and ots still not in git.

-- eric

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/