Re: [uml-devel] [PATCH] UML - Fix irqstack crash

From: Jeff Dike
Date: Mon Sep 24 2007 - 16:02:25 EST


On Thu, Sep 20, 2007 at 05:57:49PM +0200, Paolo Giarrusso wrote:
> Yes, indeed - or sign extension on 64bit machines would set to 1 the whole
> high-word.
>
> But using long for that mask makes no difference; either int or long
> long (or better, either u32 or u64) should be used, given that the
> used signal range is the same on 32 and 64bit machines, it should
> be u32 for normal signals or u64 if RT-signals are also allowed.

We don't use RT signals for anything, so we could use u32. I don't
see it making much difference though.

Jeff

--
Work email - jdike at linux dot intel dot com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/