Re: [PATCH 24/25] r/o bind mounts: track number of mount writers

From: Andrew Morton
Date: Mon Sep 24 2007 - 15:11:20 EST


On Mon, 24 Sep 2007 18:54:11 +0100
Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

> As we already say in various messages the percpu counters in here
> look rather fishy. I'd recomment to take a look at the per-cpu
> superblock counters in XFS as they've been debugged quite well
> now and could probably be lifted into a generic library for this
> kind of think. The code is mostly in fs/xfs/xfs_mount.c can
> can be spotted by beeing under #ifdef HAVE_PERCPU_SB.
>
> It also handles cases like hotplug cpu nicely that this code
> seems to work around by always iterating over all possible cpus
> which might not be nice on a dual core laptop with a distro kernel
> that also has to support big iron.

hm. How come xfs invented a new version of percpu_counters?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/