[18/50] splice: fix direct splice error handling

From: Greg KH
Date: Mon Sep 24 2007 - 12:31:34 EST

From: Jens Axboe <jens.axboe@xxxxxxxxxx>

This is a splice patch for 2.6.22 and 2.6.21 (and earlier, I did not
check. Let me know if you still maintain older stable trees!). It fixes
an infinite loop in do_splice_direct(), when there's either nothing to
read or nothing to write and blocking doesn't help. It could be things
like running out of disk space. We need to exit both for failure and
zero return, or we could be going around forever.

This got fixed in 2.6.23-git with commit 51a92c0f6ce8fa85fa0e18ecda1d847e606e8066

Herbert Poetzl <herbert@xxxxxxxxxxxx> noticed this bug in 2.6.22, and
has verified that this minimal fix works.

Signed-off-by: Jens Axboe <jens.axboe@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>

fs/splice.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--- a/fs/splice.c
+++ b/fs/splice.c
@@ -1011,7 +1011,7 @@ long do_splice_direct(struct file *in, l
max_read_len = min(len, (size_t)(PIPE_BUFFERS*PAGE_SIZE));

ret = do_splice_to(in, ppos, pipe, max_read_len, flags);
- if (unlikely(ret < 0))
+ if (unlikely(ret <= 0))
goto out_release;

read_len = ret;
@@ -1023,7 +1023,7 @@ long do_splice_direct(struct file *in, l
ret = do_splice_from(pipe, out, &out_off, read_len,
- if (unlikely(ret < 0))
+ if (unlikely(ret <= 0))
goto out_release;

bytes += ret;

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/