Re: [PATCH 02/03] CM-x270: ITE 8152 PCI bridge support

From: Mike Rapoport
Date: Fri Sep 21 2007 - 16:12:17 EST


On 9/21/07, Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> wrote:
> On Fri, Sep 21, 2007 at 12:42:55PM +0200, Guennadi Liakhovetski wrote:
> > On Thu, 20 Sep 2007, Mike Rapoport wrote:
> >
> > > This patch provides driver for ITE 8152 PCI bridge.
> > >
> > > Signed-off-by: Mike Rapoport <mike@xxxxxxxxxxxxxx>
> > >
> > > arch/arm/common/Makefile | 1 +
> > > arch/arm/common/it8152.c | 387 +++++++++++++++++++++++++++++++++++++
> >
> > Shouldn't it go to drivers/pci and define a platform driver? it8152 is not
> > an ARM specific controller.
>
> drivers/pci is currently only used for the PCI bus infrastructure. The
> setup of host bridges is very platform dependent.
>
> Also note that you should *avoid* DMA bounce wherever possible.
> The code is broken as designed. Ensure that the DMA mask is set
> appropriately, and then moan elsewhere if things don't work.

That's more or less what I'm trying to do. ITE chip allows to address
up to 64Mbyte, so I have to ensure that *no* PCI device will ever try
to DMA above that limit.
I don't see other way to ensure it.


> -------------------------------------------------------------------
> List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
> FAQ: http://www.arm.linux.org.uk/mailinglists/faq.php
> Etiquette: http://www.arm.linux.org.uk/mailinglists/etiquette.php
>


--
Sincerely Yours,
Mike.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/