Re: [PATCH] Reduce __print_symbol/sprint_symbol stack usage.
From: Paulo Marques
Date: Fri Sep 21 2007 - 11:47:51 EST
Steven Rostedt wrote:
On Wed, Sep 19, 2007 at 03:25:15PM +0100, Paulo Marques wrote:
if we change the interface from "print_symbol(fmt, addr)" to
"print_symbol(prefix, addr, int newline)" we can simply do:
printk(prefix);
printk_symbol(addr);
if (newline)
printk("\n");
NACK
I just wrote something that does "print_symbol(" %s)\n", addr);"
Notice the ")" in the output.
We can just change that to "print_symbol(prefix, addr, suffix)" instead.
The concept is basically the same (and I wasn't very fond of that
newline argument either).
As an added bonus we stop needing an extra layer to check that the
string passed is in the right format with a single "%s" in it.
--
Paulo Marques - www.grupopie.com
"Very funny Scotty. Now beam up my clothes."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/