Re: [PATCH 10/24] elevate write count during entire ncp_ioctl()

[Christoph Hellwig]

On Mon, Sep 17, 2007 at 11:27:31AM -0700, Dave Hansen wrote:
> 
> Some ioctls need write access, but others don't.  Make a helper
> function to decide when write access is needed, and take it.

The WARN_ON is too agressive because it'll happen whenever someone tries
a random, non-existant ioctl on ncpfs.  Otherwise the patch looks good.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/