Re: 2.6.23-rc4-mm1 compile error for ppc 32

From: Benjamin Herrenschmidt
Date: Sat Sep 15 2007 - 09:33:25 EST


On Thu, 2007-09-13 at 15:17 -0700, Andrew Morton wrote:

> Like this?
>
> --- a/include/asm-powerpc/bitops.h~powerpc-lock-bitops-fix
> +++ a/include/asm-powerpc/bitops.h
> @@ -226,7 +226,7 @@ static __inline__ void set_bits(unsigned
>
> static __inline__ void __clear_bit_unlock(int nr, volatile unsigned long *addr)
> {
> - __asm__ __volatile__(LWSYNC_ON_SMP ::: "memory");
> + __asm__ __volatile__(LWSYNC_ON_SMP "" ::: "memory");
> __clear_bit(nr, addr);
> }
>

Looks ok. Can somebody test ? I'm still travelling...


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/