Re: [PATCH] add consts where appropriate in sound/pci/hda/*

From: Sam Ravnborg
Date: Sat Sep 15 2007 - 06:16:55 EST


On Sat, Sep 15, 2007 at 11:43:40AM +0200, Jan Engelhardt wrote:
>
> On Sep 14 2007 18:48, Denys Vlasenko wrote:
> >Hi Takashi,
> >
> >There is a lot of data structures in that code,
> >and most of them seems to be read-only.
> >
> >I added const modifiers to most of such places:
> >
> > text data bss dec hex filename
> > 106315 179564 36 285915 45cdb snd-hda-intel.o
> > 283051 2624 36 285711 45c0f snd-hda-intel_patched.o
>
> This is kinda odd. Why did the _text_ size increase by constifying?

The data got converted from data to text because they were made const.
Making stuff const unfortunately does not make them disappear
albeit the embedded folks would have liked that.

Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/