Re: [git patches] net driver fixes

From: Dan Williams
Date: Fri Sep 14 2007 - 14:32:49 EST


On Fri, 2007-09-14 at 14:17 -0400, Jeff Garzik wrote:
> Dan Williams wrote:
> > WTF? why would the default be to _not_ propagate carrier state? Are
> > there some mitigating circumstances that require this driver to not
> > notify the stack of carrier on/off? Userspace stuff really should know
> > about the carrier state, and this disables it by default.
>
>
> The commit explains that...

I admit that I probably don't understand the system architecture of
where ehea would be used, but would this
cause /sys/class/net/ethX/carrier to be TRUE even if the device has no
carrier? That seems quite wrong IMHO. When does ehea not have a
carrier? And in that case, does sysfs say 1 or 0 for the carrier?

Dan


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/