Re: [PATCH] wake up from a serial port

From: Greg KH
Date: Thu Sep 13 2007 - 19:45:07 EST


On Wed, Sep 12, 2007 at 03:36:10PM -0700, Andrew Morton wrote:
> On Wed, 12 Sep 2007 20:50:10 +0200 (CEST)
> Guennadi Liakhovetski <g.liakhovetski@xxxxxx> wrote:
>
> > Enable wakeup from serial ports, make it run-time configurable over sysfs,
> > e.g.,
> >
> > echo enabled > /sys/devices/platform/serial8250.0/tty/ttyS0/power/wakeup
> >
> > Requires
> >
> > # CONFIG_SYSFS_DEPRECATED is not set
> >
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
> >
> > ---
> >
> > Following suggestions from Alan and Russell moved the may_wake_up checks
> > to serial_core.c. This time actually tested - it does even work. Could
> > someone, please, verify, that put_device after device_find_child is
> > correct?
>
> Seems right to me, from reading device_find_child() and its associated
> documentation.

Yes, that is correct.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/