Re: [PATCH] v4l: Build error with et61x251, if V4L1_COMPAT is not selected

From: aherrman
Date: Thu Sep 13 2007 - 18:05:21 EST


On Thu, Sep 13, 2007 at 05:07:16PM +0200, Luca Risolia wrote:
> On Thursday 13 September 2007 14:36:27 aherrman@xxxxxxxx wrote:
> > With current git tree I get an build error
> > for et61x251, if V4L1_COMPAT is not selected:
> >
> > drivers/media/video/et61x251/et61x251_core.c: In et61x251_show_:
> > drivers/media/video/et61x251/et61x251_core.c:718: error: implicit
> > declaration of to_video_device
> >
> > Fix: add VIDEO_V4L1_COMPAT as a dependency for this driver.
>
> No, wait. The driver really is V4L2 only. If you can, please fix it by
> replacing to_video_device() with container_of() instead:
>
> cam = video_get_drvdata(container_of(cd, struct video_device, class_dev));

Ah just some v4l1 remainders.
I'll do that.


Regards,

Andreas

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/