Re: [PATCH 3/4] ide: make ide_rate_filter() also respect PIO and SW/MW DMA mode masks (take 2)

From: Bartlomiej Zolnierkiewicz
Date: Tue Sep 11 2007 - 17:40:38 EST



Hi,

On Saturday 08 September 2007, Sergei Shtylyov wrote:
> Once I quothed:
>
> > Make ide_rate_filter() also respect PIO/SWDMA/MWDMA mode masks. While at it,
> > make the udma_filter() method calls take precedence over using the mode masks.
>
> This one not looking to pretty -- I've geve some thought on how to
> beautify all these switch fallthoughs but haven't got something much better
> then uour original approach (AKA Occam's razor :-).

Care to recast the patch to contain only udma_filter() part?

BTW ide_rate_filter() still lacks respecting PIO limits of the device
(Occam's razor doesn't apply to "PIO side" of ide_rate_filter() ;-)

Thanks,
Bart
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/