Re: [patch][Intel-IOMMU] Fix for IOMMU early crash

From: Paul Mackerras
Date: Tue Sep 11 2007 - 16:59:58 EST


Keshavamurthy, Anil S writes:

> Subject: Fix IOMMU early crash
>
> This patch avoids copying pci_bus's->sysdata to
> pci_dev's->sysdata as one can easily obtain
> the same through pci_dev->bus->sysdata.

At the moment this will cause ppc64 to crash, since we rely on
pci_dev->sysdata pointing to some node in the firmware device tree,
either the device's node or the node for a parent bus.

We could change the ppc64 code to use pci_dev->bus->sysdata in the
case when pci_dev->sysdata is NULL, which would fix the problem. I
think that change should be incorporated as part of this patch so that
we don't break git bisection.

In other words I don't want to see this patch applied as it stands.

Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/