Re: [RESEND][PATCH 0/4] Virtual Machine Time Accounting

From: Ingo Molnar
Date: Mon Sep 10 2007 - 08:08:24 EST



* Laurent Vivier <Laurent.Vivier@xxxxxxxx> wrote:

> Ingo, please, could you have a look to these patches ?
>
> The aim of these four patches is to introduce Virtual Machine time
> accounting.
>
> [PATCH 1/4] as recent CPUs introduce a third running state, after
> "user" and "system", we need a new field, "guest", in cpustat to store
> the time used by the CPU to run virtual CPU. Modify /proc/stat to
> display this new field.

the concept certainly looks sane to me.

The heavy-handed use of #ifdefs uglifies the code to a large degree, but
this is not a fundamental problem: since basically all distros have KVM
enabled (and lguest benefits from this too), could you just make all
this new code unconditional?

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/