Re: [patches] [patch 3/5] x86: Add PCI extended config space accessfor AMD Barcelona

From: H. Peter Anvin
Date: Wed Sep 05 2007 - 06:15:57 EST


Robert Richter wrote:
On 05.09.07 06:58:58, H. Peter Anvin wrote:

But at the moment there is no need for further discussion on this subject
because Andi refuses to add support for Barcelona CF8/CFC ECS access.

Well, they don't add any functionality, do they? As such, I would agree with Andi -- we only need one method which can (correctly) access the full configuration space, since it'll look the same on the bus anyway.

PCI Devices will not be the same on the bus since PCI read/write
functions will have different behavior. Without the patches you will
get an error when accessing ECS with CF8. We need ECS access for
patches that setups local interrupt vectors. This patches will be
released soon.

You're missing the point. How will the PCI bus transactions be different when using MMCONFIG versus your extended CF8 version?

Btw, this patch fixes also config space access with proc/sys fs and
lspci. I see this as an added functionality as well.

The latter implies the former. Again, how does this differ from MMCONFIG?

-hpa

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/