Re: [PATCH] Fix preemptible lazy mode bug

[Jeremy Fitzhardinge]

Rusty Russell wrote:
>  static inline void arch_flush_lazy_mmu_mode(void)
>  {
> -	PVOP_VCALL1(set_lazy_mode, PARAVIRT_LAZY_FLUSH);
> +	if (unlikely(__get_cpu_var(paravirt_lazy_mode) == PARAVIRT_LAZY_MMU))
> +		arch_leave_lazy_mmu_mode();
>  }
>   

This changes the semantics a bit; previously "flush" would flush
anything pending but leave us in lazy mode.  This just drops lazymode
altogether?

I guess if we assume that flushing is a rare event then its OK, but I
think the name's a bit misleading.  How does it differ from plain
arch_leave_lazy_mmu_mode()?

    J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/