Re: [-mm PATCH] Memory controller improve user interface (v3)

From: Balbir Singh
Date: Mon Sep 03 2007 - 15:51:18 EST


Paul Menage wrote:
> On 9/2/07, Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx> wrote:
>> - s += sprintf(s, "%lu\n", *val);
>> + if (read_strategy)
>> + s += read_strategy(*val, s);
>> + else
>> + s += sprintf(s, "%lu\n", *val);
>
> This would be better as %llu
>

Hi, Paul,

This does not need fixing, since the other counters like failcnt are
still unsigned long

>> + tmp = simple_strtoul(buf, &end, 10);
>
> and this as simple_strtoull()
>


Will do, thanks!



--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/