Re: [PATCH] Blackfin BF54x NAND Flash Controller driver

[David Woodhouse]

On Mon, 2007-09-03 at 15:25 +0800, Bryan Wu wrote:
> +       if (hardware_ecc) {
> +               if (plat->page_size == NFC_PG_SIZE_256) {
> +                       chip->ecc.bytes = 3;
> +                       chip->ecc.size = 256;
> +               } else if (mtd->writesize == NFC_PG_SIZE_512) { 

Comparing against plat->page_size in one case, but mtd->writesize in the
other? And elsewhere it seems plat->page_size is treated as a boolean,
indicating only 256-byte vs. 512-byte pages (you don't support 2KiB or
other page sizes at all?)

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/