Re: [PATCH -mm] IPS SCSI driver: Check return of scsi_add_host()

From: Jesper Juhl
Date: Sun Sep 02 2007 - 16:07:36 EST


On Sunday 02 September 2007 22:13:49 Satyam Sharma wrote:
>
> drivers/scsi/ips.c: In function âips_register_scsiâ:
> drivers/scsi/ips.c:6869:
> warning: ignoring return value of âscsi_add_hostâ, declared with attribute warn_unused_result
>
> scsi_add_host() is __must_check, so let's check it's return and cleanup
> appropriately on errors.
>
> Signed-off-by: Satyam Sharma <satyam@xxxxxxxxxxxxx>
>
[snip]

Something seems to be wrong either at your end or mine
> + IPS_PRINTK(KERN_WARNING, ha->pcidev, "Unable to add SCSI hostÂn");

This should end with a newline "\n" but I'm seeing "Ân" ...


/Jesper

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/