Re: nmi_watchdog=2 regression in 2.6.21

From: Daniel Walker
Date: Wed Aug 29 2007 - 21:31:22 EST


On Wed, 2007-08-29 at 14:24 -0700, Stephane Eranian wrote:


> Now on Core Duo, there is no PEBS anyway, so it is okay to use counter 0
> for NMI. The problem is that the detection code in perfctr-watchdog.c
> treats a Core Duo and a Core 2 Duo the same way as they both have the
> X86_FEATURE_ARCH_PERFMON bit set.
>
> I have attached a patch with handle the case of the Core Duo. Unfortunately,
> I do not own one so I cannot test it. I would appreciate if you could
> try re-applying my counter 0 -> 1 patch + this new one to see if you
> have the problem with the NMI getting stuck.

I tested your patch .. The system doesn't hang, but the NMI seems to
disappear .. The check_nmi_watchdog() is not called, and the NMI never
actually starts firing .. Is that what you had intended?

Daniel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/