Re: [PATCH] Add source address to sunrpc svc errors

From: Peter Staubach
Date: Wed Aug 29 2007 - 09:37:47 EST


Valdis.Kletnieks@xxxxxx wrote:
On Mon, 27 Aug 2007 17:43:33 EDT, "J. Bruce Fields" said:

Looks like a reasonable idea to me, thanks! Any objection to just
calling it "svc_printk" instead of "svc_printkerr"?

I also wonder whether these shouldn't all be dprintk's instead of
printk's. One misbehaving client could create a lot of noise in the
logs.

I shouldn't have to rebuild my kernel with debugging enabled just to see
who is throwing trash at my machine. printk(KERN_INFO maybe and/or using
a printk_ratelimit.

There are a lot of ways to discover who is throwing trash
at your system other than the kernel printing messages.

Tools such as tcpdump and tethereal/wireshark make much better
tools for this purpose.

Thanx...

ps
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/