Re: [Cbe-oss-dev] [patch 1/5] spu_manage: use newer physical-id

From: Ishizaki Kou
Date: Wed Aug 29 2007 - 05:26:55 EST



Christian Krafft wrote:
> On Thu, 23 Aug 2007 18:12:19 +0200
> Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> > On Thursday 23 August 2007, kou.ishizaki@xxxxxxxxxxxxx wrote:
> > > Please check "unit-id" if "physical-id" doesn't exist. Because
Celleb
> > > uses "unit-id" to provide spe_id.
>
> Sorry for the late answer, wasn't on cc
> and had to receive all mails of the last 6 month once again :-(
>
> Can you check if the patch below is working with celleb device tree ?
>
> ------
> Subject: spu_manage: fix spu_unit_number for celleb device tree
>
> From: Christian Krafft <krafft@xxxxxxxxxx>
>
> New device trees provide "physical-id".
> Celleb device tree provide the "unit-id".
> Legacy device tree used the reg property for the physical id of an
spe.
> This patch fixes find_spu_unit_number to look for the spu id in that
order.
> The length is checked to avoid misinterpretation in case the
attributes
> unit-id or reg do not contain the id.
>
> Signed-off-by: Christian Krafft <krafft@xxxxxxxxxx>

Acked-by: Kou Ishizaki <kou.ishizaki@xxxxxxxxxxxxx>

It works good on Celleb, thanks. Please apply it to 2.6.23.

Best regards,
Kou Ishizaki
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/