Re: [PATCH] Add documentation to some preprocessor directives in init/*.c.

From: Alexey Dobriyan
Date: Tue Aug 28 2007 - 16:42:28 EST


On Tue, Aug 28, 2007 at 01:56:24AM -0400, Robert P. J. Day wrote:
> Add some documentation to potentially confusing preprocessor
> directives in some source files in the init/ directory to show their
> proper association and nesting.

> --- a/init/calibrate.c
> +++ b/init/calibrate.c
> @@ -101,7 +101,7 @@ static unsigned long __devinit calibrate_delay_direct(void)
> "estimate for loops_per_jiffy.\nProbably due to long platform interrupts. Consider using \"lpj=\" boot option.\n");
> return 0;
> }
> -#else
> +#else /* !ARCH_HAS_READ_CURRENT_TIMER */
> static unsigned long __devinit calibrate_delay_direct(void) {return 0;}
> #endif

I'm sorry, but this is not useful. You're adding comments and compiler
ignores comments. So, one can't rely on such comments being accurate and
will go to start of section for recheck anyway.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/