Re: [PATCH] Add source address to sunrpc svc errors

From: J. Bruce Fields
Date: Tue Aug 28 2007 - 14:56:38 EST


On Tue, Aug 28, 2007 at 07:03:06PM +0100, Dr. David Alan Gilbert wrote:
> * J. Bruce Fields (bfields@xxxxxxxxxxxx) wrote:
> > I also wonder whether these shouldn't all be dprintk's instead of
> > printk's. One misbehaving client could create a lot of noise in the
> > logs.
>
> Yeh; I wasn't going to change anything else about it; the
> rate limiting (that I think Neil put in a few months ago) means
> that any one client doesn't get too noisy - I've got something
> trying to do version 0 on nfs to a bunch of boxes and I do wonder
> why; I suspect it's just a monitoring script - but it seems better
> to know about it until I figure it out.

OK.

> I'm not going to be able to recut the patch until the weekend;
> do you just want to remove the 'err' in your copy and feed this
> to the main tree with some of the rest of your patches?

Done; result at

git://linux-nfs.org/~bfields/linux.git nfs-server-stable

if you'd like to check.

--b.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/