Re: [patch] sched: fix broken smt/mc optimizations with CFS

From: Ingo Molnar
Date: Mon Aug 27 2007 - 15:23:41 EST



* Siddha, Suresh B <suresh.b.siddha@xxxxxxxxx> wrote:

> > - if (*imbalance + SCHED_LOAD_SCALE_FUZZ < busiest_load_per_task/2) {
> > + if (*imbalance + SCHED_LOAD_SCALE_FUZZ < busiest_load_per_task) {
>
> Ingo, this is still broken. This condition is always false for nice-0
> tasks..

yes - negative reniced tasks are not spread out via this - and positive
reniced tasks are spread out more easily.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/