Re: [PATCH 1/3] Implement emulator_write_phys()
From: Avi Kivity
Date: Mon Aug 27 2007 - 11:48:38 EST
Anthony Liguori wrote:
Since a hypercall may span two pages and is a gva, we need a function to write
to a gva that may span multiple pages. emulator_write_phys() seems like the
logical choice for this.
@@ -962,8 +962,35 @@ static int emulator_write_std(unsigned long addr,
unsigned int bytes,
struct kvm_vcpu *vcpu
I think that emulator_write_emulated(), except for being awkwardly
named, should do the job. We have enough APIs.
But! We may not overwrite the hypercall instruction while a vcpu may be
executing, since there's no atomicity guarantee for code fetch. We have
to to be out of guest mode while writing that insn.
--
Any sufficiently difficult bug is indistinguishable from a feature.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/