Re: [md-accel PATCH 16/19] dmaengine: driver for the iop32x, iop33x, and iop13xx raid engines

[saeed bishara]

Hi Dan,
I think you have a bug in this function, the list_splice_init adds the
new slots in the head of the chain_node, but you get the
old_chain_tail (latest descriptor) from the tail of the chain!!

 > +static dma_cookie_t
 > +iop_adma_tx_submit(struct dma_async_tx_descriptor *tx)
 > +{
 > +
 > +       old_chain_tail = list_entry(iop_chan->chain.prev,
 > +               struct iop_adma_desc_slot, chain_node);
 > +       list_splice_init(&sw_desc->group_list, &old_chain_tail->chain_node);
 > +
 > +       /* fix up the hardware chain */
 > +       iop_desc_set_next_desc(old_chain_tail, grp_start->phys);
 > +
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/