Re: [PATCH 1/1] cciss: fix error reporting for SG_IO

From: Andrew Morton
Date: Fri Aug 24 2007 - 20:11:30 EST


On Fri, 24 Aug 2007 12:53:54 -0500
"Mike Miller (OS Dev)" <mikem@xxxxxxxxxxxxxxxxxxxxxxx> wrote:

> This fixes a problem with the way cciss was filling out the "errors"
> field of the request structure upon completion of requests.
> Previously, it just put a 1 or a 0 in there and used the negation
> of this as the uptodate parameter to one of the functions in the
> block layer, being a block device. For the SG_IO ioctl, this was not
> sufficient, and we noticed that, for example, sg_turs from sg3_utils
> did not correctly detect problems due to cciss having set rq->errors
> incorrectly.

Do we think this problem is sufficiently serious to merit merging
this (largeish) patch into 2.6.23?

I'm thinking "no", but that might be wrong...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/